Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mouse button option for drag scrolling #594

Merged

Conversation

inc0der
Copy link
Contributor

@inc0der inc0der commented Mar 23, 2024

Adds a property to ScrollView to allow choosing which mouse button can be used to drag scroll. I settled on scrollMouseButton after discussing it in Discord but if you like another option, please feel free to let me know and I'll change it.

@ianharrigan
Copy link
Member

Alright, you know what, i think scrollMouseButton is the best its gonna get... so it'll be fine... one quick change though, instead of creating a whole new behaviour for it can we just do:

@:clonable @:behaviour(DefaultBehaviour, MouseButton.LEFT) public var scrollMouseButton:MouseButton;

(and remove the behaviour class)
for simple things like this, a whole behaviour class isnt needed, default should be just fine.

@inc0der inc0der force-pushed the add-scroll-mouse-button-property branch from 1a502f8 to 090f90b Compare April 6, 2024 14:29
@inc0der
Copy link
Contributor Author

inc0der commented Apr 6, 2024

Ok perfect. I changed it to a DefaultBehaviour and removed the DataBehaviour class.

@ianharrigan ianharrigan merged commit db93937 into haxeui:master Apr 6, 2024
1 check passed
@ianharrigan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants